Merged
Conversation
Major improvements: - Update minimum Python requirement from 3.8 to 3.11 - Modernize all type hints to use Python 3.11+ syntax: * Replace Dict[] with dict[] * Replace List[] with list[] * Replace Tuple[] with tuple[] * Replace Optional[T] with T | None * Remove typing imports where no longer needed - Update CI/CD to test Python 3.11, 3.12, 3.13 - Add @cache decorator to make_sincos_array() for performance - Return tuple instead of list from make_sincos_array() for immutability Benefits: - Cleaner, more readable type hints - Better performance (cached trig calculations) - Automatic 10-60% speedup from Python 3.11+ interpreter - Modern best practices aligned with current Python standards Files modified: - pyproject.toml: Updated requires-python, classifiers, tool versions - .github/workflows/validation.yml: Test Python 3.11-3.13 - All 13 source files: Modernized type hints throughout - geomagnetic.py: Added @cache for performance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Major improvements:
Benefits:
Files modified: