[core] Decompilation doesn't follow goto out of loop

[j-kaltes]

Issue details

A function is wrongly decompiled in the code and the simple section. No error or warning message is shown. The fallback decompilation is correct.
Smali:

.method public static validateAppSignature(Landroid/content/Context;[Landroid/content/pm/Signature;Z)Z
    .registers 9

    const/4 p0, 0x1

    const-string v0, "MicroMsg.SDK.WXMsgImplComm"

    if-nez p2, :cond_b

    const-string p1, "ignore wechat app signature validation"

    :goto_7
    invoke-static {v0, p1}, Lcom/tencent/mm/opensdk/utils/Log;->d(Ljava/lang/String;Ljava/lang/String;)V

    return p0

    :cond_b
    array-length p2, p1

    const/4 v1, 0x0

    move v2, v1

    :goto_e
    if-ge v2, p2, :cond_3f

    aget-object v3, p1, v2

    if-nez v3, :cond_15

    goto :goto_3c

    :cond_15
    invoke-virtual {v3}, Landroid/content/pm/Signature;->toCharsString()Ljava/lang/String;

    move-result-object v3

    invoke-virtual {v3}, Ljava/lang/String;->toLowerCase()Ljava/lang/String;

    move-result-object v3

    new-instance v4, Ljava/lang/StringBuilder;

    invoke-direct {v4}, Ljava/lang/StringBuilder;-><init>()V

    const-string v5, "check signature:"

    invoke-virtual {v4, v5}, Ljava/lang/StringBuilder;->append(Ljava/lang/String;)Ljava/lang/StringBuilder;

    invoke-virtual {v4, v3}, Ljava/lang/StringBuilder;->append(Ljava/lang/String;)Ljava/lang/StringBuilder;

    invoke-virtual {v4}, Ljava/lang/StringBuilder;->toString()Ljava/lang/String;

    move-result-object v4

    invoke-static {v0, v4}, Lcom/tencent/mm/opensdk/utils/Log;->d(Ljava/lang/String;Ljava/lang/String;)V

    const-string v4, "308202eb30820254a00302010202044d36f7a4300d06092a864886f70d01010505003081b9310b300906035504061302383631123010060355040813094775616e67646f6e673111300f060355040713085368656e7a68656e31353033060355040a132c54656e63656e7420546563686e6f6c6f6779285368656e7a68656e2920436f6d70616e79204c696d69746564313a3038060355040b133154656e63656e74204775616e677a686f7520526573656172636820616e6420446576656c6f706d656e742043656e7465723110300e0603550403130754656e63656e74301e170d3131303131393134333933325a170d3431303131313134333933325a3081b9310b300906035504061302383631123010060355040813094775616e67646f6e673111300f060355040713085368656e7a68656e31353033060355040a132c54656e63656e7420546563686e6f6c6f6779285368656e7a68656e2920436f6d70616e79204c696d69746564313a3038060355040b133154656e63656e74204775616e677a686f7520526573656172636820616e6420446576656c6f706d656e742043656e7465723110300e0603550403130754656e63656e7430819f300d06092a864886f70d010101050003818d0030818902818100c05f34b231b083fb1323670bfbe7bdab40c0c0a6efc87ef2072a1ff0d60cc67c8edb0d0847f210bea6cbfaa241be70c86daf56be08b723c859e52428a064555d80db448cdcacc1aea2501eba06f8bad12a4fa49d85cacd7abeb68945a5cb5e061629b52e3254c373550ee4e40cb7c8ae6f7a8151ccd8df582d446f39ae0c5e930203010001300d06092a864886f70d0101050500038181009c8d9d7f2f908c42081b4c764c377109a8b2c70582422125ce545842d5f520aea69550b6bd8bfd94e987b75a3077eb04ad341f481aac266e89d3864456e69fba13df018acdc168b9a19dfd7ad9d9cc6f6ace57c746515f71234df3a053e33ba93ece5cd0fc15f3e389a3f365588a9fcb439e069d3629cd7732a13fff7b891499"

    invoke-virtual {v3, v4}, Ljava/lang/String;->equals(Ljava/lang/Object;)Z

    move-result v3

    if-eqz v3, :cond_3c

    const-string p1, "pass"

    goto :goto_7

    :cond_3c
    :goto_3c
    add-int/lit8 v2, v2, 0x1

    goto :goto_e

    :cond_3f
    return v1
.end method

Fallback:

  public static boolean validateAppSignature(android.content.Context r6, android.content.pm.Signature[] r7, boolean r8) {
            r6 = 1
            java.lang.String r0 = "MicroMsg.SDK.WXMsgImplComm"
            if (r8 != 0) goto Lb
            java.lang.String r7 = "ignore wechat app signature validation"
        L7:
            com.tencent.mm.opensdk.utils.Log.d(r0, r7)
            return r6
        Lb:
            int r8 = r7.length
            r1 = 0
            r2 = r1
        Le:
            if (r2 >= r8) goto L3f
            r3 = r7[r2]
            if (r3 != 0) goto L15
            goto L3c
        L15:
            java.lang.String r3 = r3.toCharsString()
            java.lang.String r3 = r3.toLowerCase()
            java.lang.StringBuilder r4 = new java.lang.StringBuilder
            r4.<init>()
            java.lang.String r5 = "check signature:"
            r4.append(r5)
            r4.append(r3)
            java.lang.String r4 = r4.toString()
            com.tencent.mm.opensdk.utils.Log.d(r0, r4)
            java.lang.String r4 = "308202eb30820254a00302010202044d36f7a4300d06092a864886f70d01010505003081b9310b300906035504061302383631123010060355040813094775616e67646f6e673111300f060355040713085368656e7a68656e31353033060355040a132c54656e63656e7420546563686e6f6c6f6779285368656e7a68656e2920436f6d70616e79204c696d69746564313a3038060355040b133154656e63656e74204775616e677a686f7520526573656172636820616e6420446576656c6f706d656e742043656e7465723110300e0603550403130754656e63656e74301e170d3131303131393134333933325a170d3431303131313134333933325a3081b9310b300906035504061302383631123010060355040813094775616e67646f6e673111300f060355040713085368656e7a68656e31353033060355040a132c54656e63656e7420546563686e6f6c6f6779285368656e7a68656e2920436f6d70616e79204c696d69746564313a3038060355040b133154656e63656e74204775616e677a686f7520526573656172636820616e6420446576656c6f706d656e742043656e7465723110300e0603550403130754656e63656e7430819f300d06092a864886f70d010101050003818d0030818902818100c05f34b231b083fb1323670bfbe7bdab40c0c0a6efc87ef2072a1ff0d60cc67c8edb0d0847f210bea6cbfaa241be70c86daf56be08b723c859e52428a064555d80db448cdcacc1aea2501eba06f8bad12a4fa49d85cacd7abeb68945a5cb5e061629b52e3254c373550ee4e40cb7c8ae6f7a8151ccd8df582d446f39ae0c5e930203010001300d06092a864886f70d0101050500038181009c8d9d7f2f908c42081b4c764c377109a8b2c70582422125ce545842d5f520aea69550b6bd8bfd94e987b75a3077eb04ad341f481aac266e89d3864456e69fba13df018acdc168b9a19dfd7ad9d9cc6f6ace57c746515f71234df3a053e33ba93ece5cd0fc15f3e389a3f365588a9fcb439e069d3629cd7732a13fff7b891499"
            boolean r3 = r3.equals(r4)
            if (r3 == 0) goto L3c
            java.lang.String r7 = "pass"
            goto L7
        L3c:
            int r2 = r2 + 1
            goto Le
        L3f:
            return r1
    }

Code:

 public static boolean validateAppSignature(Context context, Signature[] signatureArr, boolean z) {
        String str;
        if (z) {
            for (Signature signature : signatureArr) {
                if (signature != null) {
                    String lowerCase = signature.toCharsString().toLowerCase();
                    Log.d(TAG, "check signature:" + lowerCase);
                    if (lowerCase.equals(WX_APP_SIGNATURE)) {
                        str = "pass";
                    }
                }
            }
            return false;
        }
        str = "ignore wechat app signature validation";
        Log.d(TAG, str);
        return true;
    }

The error is that after str="pass" it doesn't jump out of the loop.
A possible correct decompilation would be:

 public static boolean validateAppSignature(Context context, Signature[] signatureArr, boolean z) {
        String str;
         if (z) {
            outer:
            do {
                    for (Signature signature : signatureArr) {
                        if (signature != null) {
                            String lowerCase = signature.toCharsString().toLowerCase();
                            Log.d(TAG, "check signature:" + lowerCase);
                            if(lowerCase.equals(WX_APP_SIGNATURE)) {
                                str = "pass";
                                break outer;
                               }
                        }
                    }
                    return false;
                    } while(false);
              }
          else
            str = "ignore wechat app signature validation";
        Log.d(TAG, str);
        return true;
    }

Relevant log output or stacktrace

Provide sample and class/method full name

.class Lcom/tencent/mm/opensdk/openapi/WXApiImplComm;

Jadx version

1.5.3