Skip to content

fix: Potential fix for code scanning alert no. 3: Uncontrolled data used in path expression #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
skyoo2003 wants to merge 2 commits into from
Closed

fix: Potential fix for code scanning alert no. 3: Uncontrolled data used in path expression #22

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f363822
Potential fix for code scanning alert no. 3: Uncontrolled data used i…
skyoo2003 Apr 19, 2026
75cccf8
fix: enforce lowercase hex in ECR upload ID validation
skyoo2003 Apr 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions internal/services/ecr/store.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import (
"fmt"
"os"
"path/filepath"
"strings"
"time"

"github.com/skyoo2003/devcloud/internal/storage/sqlite"
Expand Down Expand Up @@ -387,6 +388,15 @@ func (s *ECRStore) InitiateLayerUpload(accountID, repoName string) (string, erro

// UploadLayerPart saves layer part blob to the filesystem and records the part metadata.
func (s *ECRStore) UploadLayerPart(accountID, repoName, uploadID string, partFirst, partLast int64, blob []byte) error {
// uploadID is used as a filesystem path component; enforce generated-ID format.
// InitiateLayerUpload creates 16 random bytes encoded as 32 lowercase hex chars.
if len(uploadID) != 32 || uploadID != strings.ToLower(uploadID) {
return ErrLayerUploadNotFound
}
if _, err := hex.DecodeString(uploadID); err != nil {
return ErrLayerUploadNotFound
}

// Verify upload exists.
var exists int
_ = s.db().QueryRow(`SELECT COUNT(*) FROM layers WHERE upload_id=? AND repo_name=? AND account_id=?`, uploadID, repoName, accountID).Scan(&exists)
Expand Down
Loading