Potential fix for code scanning alert no. 1: Size computation for allocation may overflow

[skyoo2003]

Potential fix for https://github.com/skyoo2003/devcloud/security/code-scanning/1

To fix this safely without changing behavior, guard the capacity computation before make(map[string]string, len(attrs)+2) so the addition cannot overflow.

Best fix in this file:

• In internal/services/cloudformation/engine.go, at the attrCache.set(...) region (around line 437), compute capHint from len(attrs), check if it is greater than math.MaxInt-2, and if so clamp to len(attrs) (or another safe value), otherwise use len(attrs)+2.
• Then allocate copyAttrs with capHint.

This preserves functionality (copy keys and optionally add "Arn") while removing overflow risk.
Needed changes:

• Add standard library import: math.
• Replace the single allocation line with guarded capacity logic.

Suggested fixes powered by Copilot Autofix. Review carefully before merging.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adds an overflow-safe capacity calculation for attribute map allocation in the CloudFormation engine’s attrCache.set method, including importing math and guarding len(attrs)+2 against integer overflow.

File-Level Changes

Change	Details	Files
Harden attribute cache map allocation against integer overflow while preserving existing behavior.	Import math from the standard library to access MaxInt for bounds checking. Introduce a capHint variable initialized from len(attrs). Guard the capacity increase with an if check against math.MaxInt-2, only adding 2 when safe to do so. Use capHint as the capacity when allocating the copyAttrs map instead of len(attrs)+2.	internal/services/cloudformation/engine.go

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}