Skip to content

fix: Potential fix for code scanning alert no. 22: Slice memory allocation with excessive size value #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skyoo2003 merged 2 commits into from
Apr 20, 2026
Merged

fix: Potential fix for code scanning alert no. 22: Slice memory allocation with excessive size value #6

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7165821
Potential fix for code scanning alert no. 22: Slice memory allocation…
skyoo2003 Apr 19, 2026
55a1776
fix: use maxRandomPasswordLength constant in error message instead of…
skyoo2003 Apr 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion internal/services/secretsmanager/provider.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -426,9 +426,16 @@ func (p *Provider) cancelRotateSecret(params map[string]any) (*plugin.Response,
// allowedChars is the default character pool for random passwords.
const allowedChars = "abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789!@#$%^&*()-_=+[]{}|;:,.<>?"

// maxRandomPasswordLength caps user-controlled password length to prevent
// excessive memory allocation from untrusted input.
const maxRandomPasswordLength = 4096

func (p *Provider) getRandomPassword(params map[string]any) (*plugin.Response, error) {
length := 32
if l, ok := params["PasswordLength"].(float64); ok && l > 0 {
if l, ok := params["PasswordLength"].(float64); ok {
if l <= 0 || l > maxRandomPasswordLength {
return smError("InvalidParameterException", fmt.Sprintf("PasswordLength must be between 1 and %d", maxRandomPasswordLength), http.StatusBadRequest), nil
}
length = int(l)
}
excludeChars, _ := params["ExcludeCharacters"].(string)
Expand Down
Loading