new serialization for js <-> cpp interaction

[aw-c]

Important

Add NapiOutputArchive for C++ to JavaScript serialization and update Inventory class and CMake configuration accordingly.

• Serialization:
  • Add NapiOutputArchive class in NapiOutputArchive.h for serializing C++ objects to JavaScript objects using Node-API.
  • Supports serialization of integral, string, array, container, arithmetic, and optional types.
• Inventory Class:
  • Add ToNapiObject() method in Inventory.cpp to serialize Inventory objects to JavaScript objects using NapiOutputArchive.
  • Include NapiOutputArchive.h and <napi.h> in Inventory.cpp and Inventory.h.
• CMake Configuration:
  • Update CMakeLists.txt to find and link unofficial-node-addon-api.

^{This description was created by for 9323adc. It will automatically update as commits are pushed.}

[ellipsis-dev]

❌ Changes requested. Reviewed everything up to 9323adc in 2 minutes and 10 seconds

More details

• Looked at 227 lines of code in 4 files
• Skipped 0 files when reviewing.
• Skipped posting 4 drafted comments based on config settings.

1. serialization/include/archives/NapiOutputArchive.h:32

• Draft comment:
  Avoid using 'static_assert(!sizeof(T), "not string")'. This always fails when instantiated. Consider using a dependent false idiom (e.g., 'static_assert(always_false::value, "not a string type")') to disable this overload via SFINAE.
• Reason this comment was not posted:
  Marked as duplicate.

2. skymp5-server/cpp/server_guest_lib/Inventory.cpp:200

• Draft comment:
  Most vexing parse: 'NapiOutputArchive ar();' is interpreted as a function declaration rather than an object. Use 'NapiOutputArchive ar(env);' (or brace initialization) to properly instantiate the archive with the environment.
• Reason this comment was not posted:
  Marked as duplicate.

3. skymp5-server/cpp/server_guest_lib/Inventory.cpp:201

• Draft comment:
  Usage of 'const_cast' to call Serialize() suggests that Serialize might modify the object. Consider revisiting the design to either allow Serialize() to be const if it only affects serialization state, or avoid const_cast to maintain const-correctness.
• Reason this comment was not posted:
  Confidence changes required: 50% <= threshold 50%
  None

4. skymp5-server/cpp/server_guest_lib/Inventory.cpp:200

• Draft comment:
  Typographical issue: the declaration 'NapiOutputArchive ar();' in Inventory::ToNapiObject() is interpreted by the C++ compiler as a function declaration (due to the most vexing parse) instead of an object instantiation. It should be changed to 'NapiOutputArchive ar;' to correctly create an instance of NapiOutputArchive.
• Reason this comment was not posted:
  Marked as duplicate.

Workflow ID: wflow_TuXrSKOOzjgJHvG4

---

Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[ellipsis-dev]

Avoid most vexing parse: 'NapiOutputArchive ar();' declares a function instead of instantiating an object. Use 'NapiOutputArchive ar(env);' instead.

Suggested change

	NapiOutputArchive ar();
	NapiOutputArchive ar(env);

[ellipsis-dev]

The static_assert in the StringLike overload always fails because sizeof(T) is never 0. Consider using a dependent false typetrick instead.

Suggested change

	static_assert(!sizeof(T), "not string");
	static_assert(std::false_type::value, "not string");

[aw-c]

Ой, там да, есть прикол с jsEngine. По другому env должен передаваться

[nic11]

Please format with clang-format

1. 2 spaces for indents
2. { on the same line for if-s and for-s

[nic11]

Please keep in line with the current conventions https://github.com/skyrim-multiplayer/skymp/blob/main/docs/docs_cpp_code_guidelines.md

Suggested change

	Napi::Value extract_output()
	Napi::Value ExtractOutput()

[nic11]

Currently, there is no rule to prefix member names m_

[nic11]

We'd also have to change this to more meaningful messages before merge. Feel free to keep it as it is while it's wip though