Skip to content

Conversation

@Tais0ft
Copy link

@Tais0ft Tais0ft commented Oct 29, 2025

Important

Ensure ragdoll physics are applied to non-player actors upon death in remoteServer.ts.

  • Behavior:
    • Adds forceAddRagdollToWorld() call for non-player actors when they die in onCreateActorMessage() and onUpdatePropertyMessage().
    • Ensures ragdoll is added for offscreen deaths in onDeathStateContainerMessage().
  • Functions:
    • Modifies onCreateActorMessage() to handle msg.isDead and !msg.isMe by adding ragdoll.
    • Updates onUpdatePropertyMessage() to add ragdoll for non-player deaths.
    • Enhances onDeathStateContainerMessage() to ensure ragdoll for offscreen actor deaths.

This description was created by Ellipsis for cd1f67a. You can customize this summary. It will automatically update as commits are pushed.

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Changes requested ❌

Reviewed everything up to cd1f67a in 2 minutes and 16 seconds. Click for details.
  • Reviewed 39 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. skymp5-client/src/services/services/remoteServer.ts:339
  • Draft comment:
    Ragdoll is forced immediately for non-player dead actors. Consider adding a comment or ensuring the timing (within onceLoad) is safe and consistent with actor lifecycle.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% The comment suggests ensuring the timing is safe and consistent, which violates the rule against asking the PR author to ensure behavior is intended. It also suggests adding a comment, which is purely informative. Therefore, this comment should be removed.
2. skymp5-client/src/services/services/remoteServer.ts:622
  • Draft comment:
    A second forceAddRagdollToWorld call is added via once('update'). Verify that this isn't redundant with the earlier ragdoll call and that both are needed across actor creation branches.
  • Reason this comment was not posted:
    Comment looked like it was already resolved.

Workflow ID: wflow_35gx3euDGRq5JucB

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

if (actor) {
if (msgData === true && id !== this.getWorldModel().playerCharacterFormIdx) {
// Ensure ragdoll exists if actor died offscreen
Actor.from(actor)?.forceAddRagdollToWorld();
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using Actor.from(actor) on an already obtained actor instance appears redundant. Consider calling forceAddRagdollToWorld() directly on the actor.

Suggested change
Actor.from(actor)?.forceAddRagdollToWorld();
actor?.forceAddRagdollToWorld();

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant