Open
Conversation
JHeathUKAEA
reviewed
Nov 23, 2023
JHeathUKAEA
requested changes
Nov 23, 2023
Collaborator
JHeathUKAEA
left a comment
There was a problem hiding this comment.
- Has a regression test for inflamation-analysis.py been added/updated (does it calculate the correct standard deviation).
- Additional tests for bad entry could be added into s_dev().
…n this branch which were different from main branch
sl6391
commented
Nov 23, 2023
Owner
Author
sl6391
left a comment
There was a problem hiding this comment.
These suggestions should now be resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test to create pull request