Skip to content

Add implementation of standard deviation on data#1

Open
sl6391 wants to merge 3 commits intomainfrom
feature-std-dev
Open

Add implementation of standard deviation on data#1
sl6391 wants to merge 3 commits intomainfrom
feature-std-dev

Conversation

@sl6391
Copy link
Copy Markdown
Owner

@sl6391 sl6391 commented Nov 23, 2023

Test to create pull request

Comment thread inflammation/models.py
Copy link
Copy Markdown
Collaborator

@JHeathUKAEA JHeathUKAEA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Has a regression test for inflamation-analysis.py been added/updated (does it calculate the correct standard deviation).
  2. Additional tests for bad entry could be added into s_dev().

…n this branch which were different from main branch
Copy link
Copy Markdown
Owner Author

@sl6391 sl6391 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These suggestions should now be resolved

@sl6391 sl6391 removed the request for review from RoeBuckRoe November 24, 2023 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants