feat: feedback block #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srtaalej
commented
Sep 24, 2025
| python3 app.py | ||
| ``` | ||
|
|
||
| Start talking to the bot! Start a new DM or thread and click the feedback button when it responds. |
Contributor
Author
There was a problem hiding this comment.
@lukegalbraithrussell me trying to check items off of @mwbrooks wishlist 🆘
mwbrooks
approved these changes
Sep 25, 2025
Member
mwbrooks
left a comment
mwbrooks
left a comment
There was a problem hiding this comment.
✅ Looking great to me! Nice work @srtaalej! 🎉
🧪 Tested manually and I was able to see the feedback buttons and receive the message.
📝 I've left a minor nit suggestion, but it's non-blocking to merge this PR whenever you're ready!
Member
|
🧪 Just did a quick manual test after the latest commits - Text Streaming and Feedback Buttons work! 🚀 |
|
|
||
| :::info[The `listeners/events` folder is purely educational and demonstrates alternative approaches to implementation] | ||
| These listeners are **not registered** and are not used in the actual application. For the working implementation, refer to `listeners/assistant.py`. | ||
| > [!NOTE] |
There was a problem hiding this comment.
this is good! i have no idea why i suggested to use our docs syntax in a readme - i got mixed up with which repo i was commenting on probably
mwbrooks
reviewed
Sep 25, 2025
| @@ -1,5 +1,4 @@ | |||
| --extra-index-url=https://test.pypi.org/simple/ | |||
| slack_sdk==3.36.0.dev2 | |||
| slack-sdk==3.36.0.dev3 | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Summary
adds feedback block to llm responses
Requirements