Add missing event data types#1332
Merged
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1332 +/- ##
============================================
- Coverage 75.02% 74.95% -0.07%
+ Complexity 4187 4186 -1
============================================
Files 446 451 +5
Lines 12920 12930 +10
Branches 1331 1331
============================================
- Hits 9693 9692 -1
- Misses 2455 2466 +11
Partials 772 772 ☔ View full report in Codecov by Sentry. |
2 tasks
seratch
commented
Jul 2, 2024
| @@ -0,0 +1,13 @@ | |||
| package com.slack.api.app_backend.events.handler; | |||
Contributor
Author
There was a problem hiding this comment.
These handlers are legacy ones (meaning these are not used in bolt-java), but I've added them this time. In the future, we may want to deprecate them since v2.
Contributor
Author
|
FYI for reviewers, all you need to do for Events API are 1) add event classes 2) add payload wrapper classes. Once they are added, you can refer to them in bolt-java without any changes on bolt-java side. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While auditing the latest updates on the platform, I found that a few events are not yet supported in this SDK.
Category (place an
xin each of the[ ])Requirements
Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you agree to those rules.