-
Notifications
You must be signed in to change notification settings - Fork 678
fix(web-api): remove bounds on assistant.threads.setSuggestedPrompts prompts count in types #2297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(web-api): remove bounds on assistant.threads.setSuggestedPrompts prompts count in types #2297
Conversation
…prompts count in types
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #2297 +/- ##
=======================================
Coverage 92.71% 92.71%
=======================================
Files 38 38
Lines 10607 10607
Branches 683 683
=======================================
Hits 9834 9834
Misses 761 761
Partials 12 12
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
📝 Testing notes for the kind reviewers can use changes to the sample of slack-samples/bolt-js-assistant-template#48 and this PR: $ npm pack # Package these changes before testing the sample app
$ cd ~/path/to/bolt-js
$ npm install ../node-slack-sdk/packages/web-api
$ npm pack
$ cd
$ slack create asdf -t slack-samples/bolt-js-assistant-template -b zimeg-fix-suggested-prompts-types
$ cd asdf
$ npm run check # Attempt the type check test
$ npm install ../path/to/node-slack-sdk/packages/web-api # Install these changes
$ npm run check # Confirm the sample passes the type check🗣️ Unrelated errors might be addressed in #2296! |
WilliamBergamin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
![]()
|
@WilliamBergamin Indeed. 🚢 💨 I'll plan to release this soon and bring similar changes and an update to |
Summary
This PR removes the minimum bounds in types for the
assistant.threads.setSuggestedPromptsmethodpromptsproperty.Fixes issues noted in slack-samples/bolt-js-assistant-template#46 and slackapi/bolt-js#2506.
Notes
Requirements