Skip to content

Add file_ids to chat.update parameters #1187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
seratch merged 1 commit into from
Feb 24, 2022
Merged

Add file_ids to chat.update parameters #1187

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion slack_sdk/web/async_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2211,6 +2211,7 @@ async def chat_update(
attachments: Optional[Sequence[Union[Dict, Attachment]]] = None,
blocks: Optional[Sequence[Union[Dict, Block]]] = None,
as_user: Optional[bool] = None,
file_ids: Optional[Union[str, Sequence[str]]] = None,
link_names: Optional[bool] = None,
parse: Optional[str] = None, # none, full
reply_broadcast: Optional[bool] = None,
Expand All @@ -2232,6 +2233,10 @@ async def chat_update(
"reply_broadcast": reply_broadcast,
}
)
if isinstance(file_ids, (list, Tuple)):
kwargs.update({"file_ids": ",".join(file_ids)})
else:
kwargs.update({"file_ids": file_ids})
_parse_web_class_objects(kwargs)
kwargs = _remove_none_values(kwargs)
_warn_if_text_is_missing("chat.update", kwargs)
Expand Down Expand Up @@ -2448,7 +2453,7 @@ async def conversations_inviteShared(
else:
kwargs.update({"emails": emails})
if isinstance(user_ids, (list, Tuple)):
kwargs.update({"emails": ",".join(user_ids)})
kwargs.update({"user_ids": ",".join(user_ids)})
Copy link
Copy Markdown
Contributor Author

@seratch seratch Feb 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been a bug

Copy link
Copy Markdown
Contributor

@filmaj filmaj Feb 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

else:
kwargs.update({"user_ids": user_ids})
return await self.api_call(
Expand Down
7 changes: 6 additions & 1 deletion slack_sdk/web/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2160,6 +2160,7 @@ def chat_update(
attachments: Optional[Sequence[Union[Dict, Attachment]]] = None,
blocks: Optional[Sequence[Union[Dict, Block]]] = None,
as_user: Optional[bool] = None,
file_ids: Optional[Union[str, Sequence[str]]] = None,
link_names: Optional[bool] = None,
parse: Optional[str] = None, # none, full
reply_broadcast: Optional[bool] = None,
Expand All @@ -2181,6 +2182,10 @@ def chat_update(
"reply_broadcast": reply_broadcast,
}
)
if isinstance(file_ids, (list, Tuple)):
kwargs.update({"file_ids": ",".join(file_ids)})
else:
kwargs.update({"file_ids": file_ids})
_parse_web_class_objects(kwargs)
kwargs = _remove_none_values(kwargs)
_warn_if_text_is_missing("chat.update", kwargs)
Expand Down Expand Up @@ -2395,7 +2400,7 @@ def conversations_inviteShared(
else:
kwargs.update({"emails": emails})
if isinstance(user_ids, (list, Tuple)):
kwargs.update({"emails": ",".join(user_ids)})
kwargs.update({"user_ids": ",".join(user_ids)})
else:
kwargs.update({"user_ids": user_ids})
return self.api_call(
Expand Down
7 changes: 6 additions & 1 deletion slack_sdk/web/legacy_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2171,6 +2171,7 @@ def chat_update(
attachments: Optional[Sequence[Union[Dict, Attachment]]] = None,
blocks: Optional[Sequence[Union[Dict, Block]]] = None,
as_user: Optional[bool] = None,
file_ids: Optional[Union[str, Sequence[str]]] = None,
link_names: Optional[bool] = None,
parse: Optional[str] = None, # none, full
reply_broadcast: Optional[bool] = None,
Expand All @@ -2192,6 +2193,10 @@ def chat_update(
"reply_broadcast": reply_broadcast,
}
)
if isinstance(file_ids, (list, Tuple)):
kwargs.update({"file_ids": ",".join(file_ids)})
else:
kwargs.update({"file_ids": file_ids})
_parse_web_class_objects(kwargs)
kwargs = _remove_none_values(kwargs)
_warn_if_text_is_missing("chat.update", kwargs)
Expand Down Expand Up @@ -2406,7 +2411,7 @@ def conversations_inviteShared(
else:
kwargs.update({"emails": emails})
if isinstance(user_ids, (list, Tuple)):
kwargs.update({"emails": ",".join(user_ids)})
kwargs.update({"user_ids": ",".join(user_ids)})
else:
kwargs.update({"user_ids": user_ids})
return self.api_call(
Expand Down