chore: remove 3.6 references #1735

ewanek1 · 2025-09-04T21:18:04Z

Summary

Remove Python 3.6 support by updating all references to reflect the minimum of Python 3.7+.

Testing

n/a

Requirements

I've read and understood the Contributing Guidelines and have done my best effort to follow them.
I've read and agree to the Code of Conduct.
I've run python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.sh after making the changes.

codecov · 2025-09-04T21:19:00Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.88%. Comparing base (d4fc142) to head (25ba174).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1735      +/-   ##
==========================================
- Coverage   84.91%   84.88%   -0.04%     
==========================================
  Files         113      113              
  Lines       12895    12895              
==========================================
- Hits        10950    10946       -4     
- Misses       1945     1949       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

WilliamBergamin

Great work 💯 thanks for putting this together

I left a few comments they are mainly minor ones 🚀 these dependency support version type changes are always more complicated then expected

WilliamBergamin · 2025-09-05T13:45:44Z

README.md

 ---

-This library requires Python 3.6 and above. If you require Python 2, please use our [SlackClient - v1.x][slackclientv1]. If you're unsure how to check what version of Python you're on, you can check it using the following:
+This library requires Python 3.7 and above. If you require Python 2, please use our [SlackClient - v1.x][slackclientv1]. If you're unsure how to check what version of Python you're on, you can check it using the following:


We should also remove the python 2 sentence 😅 the slackClient - v1.x is deprecated

Suggested change

This library requires Python 3.7 and above. If you require Python 2, please use our [SlackClient - v1.x][slackclientv1]. If you're unsure how to check what version of Python you're on, you can check it using the following:

This library requires Python 3.7 and above. If you're unsure how to check what version of Python you're on, you can check it using the following:

WilliamBergamin · 2025-09-05T13:47:12Z

docs/english/legacy/index.md

 Slack APIs allow anyone to build full featured integrations that extend and expand the capabilities of your Slack workspace. These APIs allow you to build applications that interact with Slack just like the people on your team. They can post messages, respond to events that happen, and build complex UIs for getting work done.

-To make it easier for Python programmers to build Slack applications, we've provided this open source SDK that will help you get started building Python apps as quickly as possible. The current version is built for Python 3.6 and higher — if you need to target Python 2.x, you might consider using v1 of the SDK.
+To make it easier for Python programmers to build Slack applications, we've provided this open source SDK that will help you get started building Python apps as quickly as possible. The current version is built for Python 3.7 and higher — if you need to target Python 2.x, you might consider using v1 of the SDK.


Same here

Suggested change

To make it easier for Python programmers to build Slack applications, we've provided this open source SDK that will help you get started building Python apps as quickly as possible. The current version is built for Python 3.7 and higher — if you need to target Python 2.x, you might consider using v1 of the SDK.

To make it easier for Python programmers to build Slack applications, we've provided this open source SDK that will help you get started building Python apps as quickly as possible. The current version is built for Python 3.7 and higher.

WilliamBergamin · 2025-09-05T13:47:52Z

docs/english/v3-migration.md

 ### Minimum Python versions {#minimum-versions}

-`slackclient` v2.x requires Python 3.6 (or higher). Support for Python 2.7 is maintained in the existing `slackclient` v1.x.
+`slackclient` v2.x requires Python 3.7 (or higher). Support for Python 2.7 is maintained in the existing `slackclient` v1.x.


Same here

Suggested change

`slackclient` v2.x requires Python 3.7 (or higher). Support for Python 2.7 is maintained in the existing `slackclient` v1.x.

`slackclient` v2.x requires Python 3.7 (or higher).

WilliamBergamin · 2025-09-05T13:48:34Z

integration_tests/web/test_issue_480.py

        self.assertEqual(0, after - before)

-    # fails with Python 3.6
+    # fails with Python 3.6 (no longer supported)


I think we can remove this comment entirely 💯

WilliamBergamin · 2025-09-05T13:49:00Z

integration_tests/web/test_issue_480.py

        self.assertEqual(0, after - before)

-    # fails with Python 3.6
+    # fails with Python 3.6 (no longer supported)


This one also 🚀

WilliamBergamin · 2025-09-05T13:55:14Z

requirements/testing.txt

+black>=22.8.0; python_version=="3.7"
+black==22.10.0; python_version>="3.8"


I think this might be the reason why the CI tests are failing 🤔
Since we aren't supporting 3.6 anymore we can remove the special case and just keep a global one, like black==22.10.0, but let me know what you think?

Suggested change

black>=22.8.0; python_version=="3.7"

black==22.10.0; python_version>="3.8"

black==22.10.0;

Ah yes I agree. Black v22.10.0 supports python 3.7 so the split requirement doesn’t seem to be needed anymore!

WilliamBergamin · 2025-09-05T13:58:24Z

slack_sdk/web/internal_utils.py

    Returns:
        The user agent string.
-        e.g. 'Python/3.6.7 slackclient/2.0.0 Darwin/17.7.0'
+        e.g. 'Python/3.7.0 slackclient/2.0.0 Darwin/17.7.0'


NIT: lets use 3.7.17 since its the latest 3.7 version and a security release

WilliamBergamin · 2025-09-05T13:59:12Z

slack_sdk/web/internal_utils.py

                'Content-Type': 'application/json;charset=utf-8',
                'Authorization': 'Bearer xoxb-1234-1243',
-                'User-Agent': 'Python/3.6.8 slack/2.1.0 Darwin/17.7.0'
+                'User-Agent': 'Python/3.7.0 slack/2.1.0 Darwin/17.7.0'


NIT: lets use 3.7.17 since its the latest 3.7 version and a security release

WilliamBergamin · 2025-09-05T14:00:03Z

tests/test_aiohttp_version_checker.py

        validate_aiohttp_version("2.1.3", print)
        self.assertEqual(state["counter"], 1)
-        validate_aiohttp_version("3.6.3", print)
+        validate_aiohttp_version("3.7.0", print)


I think we want to keep this since this test covers "not recommended versions"

WilliamBergamin · 2025-09-05T14:00:35Z

tutorial/README.md

 ```
 $ python3 --version
-> Python 3.6.7
+-> Python 3.7.0


NIT: lets use 3.7.17 since its the latest 3.7 version and a security release

WilliamBergamin

Thanks for addressing all the comments 💯 🚀

There are 2 minor ones left that related to code comments, once addressed, we should be all clear and ready to merge 🚢

WilliamBergamin · 2025-09-05T17:11:59Z

slack/web/async_internal_utils.py

                'Content-Type': 'application/json;charset=utf-8',
                'Authorization': 'Bearer xoxb-1234-1243',
-                'User-Agent': 'Python/3.6.8 slack/2.1.0 Darwin/17.7.0'
+                'User-Agent': 'Python/3.7.0 slack/2.1.0 Darwin/17.7.0'


NIT: what do you think about keeping this consistent with slack_sdk/web/internal_utils.py

Suggested change

'User-Agent': 'Python/3.7.0 slack/2.1.0 Darwin/17.7.0'

'User-Agent': 'Python/3.7.17 slack/2.1.0 Darwin/17.7.0'

WilliamBergamin

🚢 Nice work 💯

WilliamBergamin · 2025-09-08T20:58:57Z

Once slackapi/bolt-python#1359 is merged and release we can merge and release these changes 🚀

Remove Python 3.6 refs.

07da9c1

ewanek1 requested review from WilliamBergamin and zimeg September 4, 2025 21:18

ewanek1 added the dependencies Pull requests that update a dependency file label Sep 4, 2025

ewanek1 added 3 commits September 4, 2025 15:28

Fix Black version for Python 3.7.

73bffb0

Fix greenlet removal.

863c41a

Fix greenlet removal.

91fa478

WilliamBergamin requested changes Sep 5, 2025

View reviewed changes

Address comments and simplify black versioning.

26ba131

WilliamBergamin requested changes Sep 5, 2025

View reviewed changes

Specifying version 3.7.17.

25ba174

WilliamBergamin added this to the 3.37.0 milestone Sep 5, 2025

WilliamBergamin added semver:minor Version: 3x python Pull requests that update Python code labels Sep 5, 2025

WilliamBergamin approved these changes Sep 5, 2025

View reviewed changes

WilliamBergamin merged commit 64e1f30 into main Sep 9, 2025
12 checks passed

WilliamBergamin deleted the remove-python36 branch September 9, 2025 19:54

WilliamBergamin mentioned this pull request Sep 9, 2025

chore: clean up project based on 3.6 removal #1736

Merged

15 tasks

	This library requires Python 3.7 and above. If you require Python 2, please use our [SlackClient - v1.x][slackclientv1]. If you're unsure how to check what version of Python you're on, you can check it using the following:
	This library requires Python 3.7 and above. If you're unsure how to check what version of Python you're on, you can check it using the following:

	To make it easier for Python programmers to build Slack applications, we've provided this open source SDK that will help you get started building Python apps as quickly as possible. The current version is built for Python 3.7 and higher — if you need to target Python 2.x, you might consider using v1 of the SDK.
	To make it easier for Python programmers to build Slack applications, we've provided this open source SDK that will help you get started building Python apps as quickly as possible. The current version is built for Python 3.7 and higher.

	`slackclient` v2.x requires Python 3.7 (or higher). Support for Python 2.7 is maintained in the existing `slackclient` v1.x.
	`slackclient` v2.x requires Python 3.7 (or higher).

		black>=22.8.0; python_version=="3.7"
		black==22.10.0; python_version>="3.8"

	black>=22.8.0; python_version=="3.7"
	black==22.10.0; python_version>="3.8"
	black==22.10.0;

	'User-Agent': 'Python/3.7.0 slack/2.1.0 Darwin/17.7.0'
	'User-Agent': 'Python/3.7.17 slack/2.1.0 Darwin/17.7.0'

chore: remove 3.6 references #1735

chore: remove 3.6 references #1735

Uh oh!

Conversation

ewanek1 commented Sep 4, 2025

Summary

Testing

Category

Requirements

Uh oh!

codecov bot commented Sep 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

WilliamBergamin left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

WilliamBergamin left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

WilliamBergamin left a comment

Choose a reason for hiding this comment

Uh oh!

WilliamBergamin commented Sep 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov bot commented Sep 4, 2025 •

edited

Loading

WilliamBergamin commented Sep 8, 2025 •

edited

Loading