Skip to content

fix(web-api): use json content type for chat stream methods #1749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zimeg merged 4 commits into from
Sep 23, 2025
Merged

fix(web-api): use json content type for chat stream methods #1749

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
de72f66
fix(web-api): use json content type for chat stream methods
zimeg Sep 23, 2025
f36cb28
test: confirm blocks can be passed to stop stream
zimeg Sep 23, 2025
2f14586
style: lint
zimeg Sep 23, 2025
65881da
Merge branch 'ai-apps' into zimeg-fix-web-api-chat-stream-json
zimeg Sep 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions slack_sdk/web/async_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2641,7 +2641,8 @@ async def chat_appendStream(
"markdown_text": markdown_text,
}
)
return await self.api_call("chat.appendStream", params=kwargs)
kwargs = _remove_none_values(kwargs)
return await self.api_call("chat.appendStream", json=kwargs)

async def chat_delete(
self,
Expand Down Expand Up @@ -2895,7 +2896,8 @@ async def chat_startStream(
"unfurl_media": unfurl_media,
}
)
return await self.api_call("chat.startStream", params=kwargs)
kwargs = _remove_none_values(kwargs)
return await self.api_call("chat.startStream", json=kwargs)

async def chat_stopStream(
self,
Expand All @@ -2920,7 +2922,8 @@ async def chat_stopStream(
}
)
_parse_web_class_objects(kwargs)
return await self.api_call("chat.stopStream", params=kwargs)
kwargs = _remove_none_values(kwargs)
return await self.api_call("chat.stopStream", json=kwargs)

async def chat_unfurl(
self,
Expand Down
9 changes: 6 additions & 3 deletions slack_sdk/web/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2631,7 +2631,8 @@ def chat_appendStream(
"markdown_text": markdown_text,
}
)
return self.api_call("chat.appendStream", params=kwargs)
kwargs = _remove_none_values(kwargs)
return self.api_call("chat.appendStream", json=kwargs)

def chat_delete(
self,
Expand Down Expand Up @@ -2885,7 +2886,8 @@ def chat_startStream(
"unfurl_media": unfurl_media,
}
)
return self.api_call("chat.startStream", params=kwargs)
kwargs = _remove_none_values(kwargs)
return self.api_call("chat.startStream", json=kwargs)

def chat_stopStream(
self,
Expand All @@ -2910,7 +2912,8 @@ def chat_stopStream(
}
)
_parse_web_class_objects(kwargs)
return self.api_call("chat.stopStream", params=kwargs)
kwargs = _remove_none_values(kwargs)
return self.api_call("chat.stopStream", json=kwargs)

def chat_unfurl(
self,
Expand Down
9 changes: 6 additions & 3 deletions slack_sdk/web/legacy_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2643,7 +2643,8 @@ def chat_appendStream(
"markdown_text": markdown_text,
}
)
return self.api_call("chat.appendStream", params=kwargs)
kwargs = _remove_none_values(kwargs)
return self.api_call("chat.appendStream", json=kwargs)

def chat_delete(
self,
Expand Down Expand Up @@ -2897,7 +2898,8 @@ def chat_startStream(
"unfurl_media": unfurl_media,
}
)
return self.api_call("chat.startStream", params=kwargs)
kwargs = _remove_none_values(kwargs)
return self.api_call("chat.startStream", json=kwargs)

def chat_stopStream(
self,
Expand All @@ -2922,7 +2924,8 @@ def chat_stopStream(
}
)
_parse_web_class_objects(kwargs)
return self.api_call("chat.stopStream", params=kwargs)
kwargs = _remove_none_values(kwargs)
return self.api_call("chat.stopStream", json=kwargs)

def chat_unfurl(
self,
Expand Down
6 changes: 4 additions & 2 deletions tests/slack_sdk_async/web/test_web_client_coverage.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -571,8 +571,10 @@ async def run_method(self, method_name, method, async_method):
self.api_methods_to_call.remove(method(channel="C123")["method"])
await async_method(channel="C123")
elif method_name == "chat_stopStream":
self.api_methods_to_call.remove(method(channel="C123", ts="123.123")["method"])
await async_method(channel="C123", ts="123.123")
self.api_methods_to_call.remove(
method(channel="C123", ts="123.123", blocks=[{"type": "markdown", "text": "**twelve**"}])["method"]
)
await async_method(channel="C123", ts="123.123", blocks=[{"type": "markdown", "text": "**twelve**"}])
elif method_name == "chat_unfurl":
self.api_methods_to_call.remove(
method(
Expand Down