Skip to content

Require Node 12, update deps, fix PnP compatibility#1

Merged
slorber merged 1 commit intoslorber:masterfrom
RDIL:master
Nov 30, 2021
Merged

Require Node 12, update deps, fix PnP compatibility#1
slorber merged 1 commit intoslorber:masterfrom
RDIL:master

Conversation

@RDIL
Copy link

@RDIL RDIL commented Nov 28, 2021

  • Bump version to 1.5.0
  • Require Node 12, since 10 is EOL and D2 requires 12 anyway
  • Updated dependencies
  • Fix PnP (this package imports sharp and jimp but doesn't have them set as dependencies, which makes the require call unambiguous and unsound)

@Josh-Cena
Copy link

@slorber Friendly ping as well

@slorber
Copy link
Owner

slorber commented Nov 30, 2021

Thanks, LGTM 👍

@slorber slorber merged commit 4e13a0a into slorber:master Nov 30, 2021
@slorber
Copy link
Owner

slorber commented Nov 30, 2021

1.5 is published 👍 let me know if it works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants