-
Notifications
You must be signed in to change notification settings - Fork 274
content: draft: Add attested build environment track #1115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
content: draft: Add attested build environment track #1115
Conversation
✅ Deploy Preview for slsa ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
e505871 to
5a2a961
Compare
|
FYI if you want to make the linter happy easily this might help. The linter caused me a ton of trouble until I figured this out. |
TomHennen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like where this is heading :)
cbf816f to
7a39858
Compare
dbc5dd1 to
8846927
Compare
8df324b to
08b92e8
Compare
TomHennen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for these changes!
This generally LGTM, I would also like to see what @deeglaze thinks about it too.
Signed-off-by: Marcela Melara <marcela.melara@intel.com>
Signed-off-by: Marcela Melara <marcela.melara@intel.com>
Signed-off-by: Marcela Melara <marcela.melara@intel.com>
Co-authored-by: Dionna Amalie Glaze <drdeeglaze@gmail.com> Signed-off-by: Marcela Melara <marcela.melara@intel.com>
Signed-off-by: Marcela Melara <marcela.melara@intel.com>
Signed-off-by: Marcela Melara <marcela.melara@intel.com>
4610a2c to
c0c8105
Compare
Signed-off-by: Marcela Melara <marcela.melara@intel.com>
Co-authored-by: Andrew McNamara <arewm@users.noreply.github.com> Signed-off-by: Marcela Melara <marcela.melara@intel.com>
Signed-off-by: Marcela Melara <marcela.melara@intel.com>
TomHennen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an amazing start.
I think we can continue to iterate on this draft in other issues & PRs.
Thanks Marcela!
|
FYI updated title to indicate this is draft! |
arewm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this draft content. Many of the topics that I have raised have moved to issues. Partially for my reference (because there were so many threads), I think the conversation has moved here:
- Potential clarification for hosted terminology: #947
- Which parts of the build system should this apply to: #1211
- Clarifications of where/how to use provenance vs VSA: #974; #1148
- Missing figure: #1165
- Consistency of terminology/definitions: #1177 (additionally, build image producer should be explicit about the party/parties involved #1115 (comment))
- Agent-less build environments: #1185
- Connection between build and build environment track: #1210
- Attestation flow including how/when to verify: #1169
- VM and container differentiation: #1192
Requesting to add @paveliak as a maintainer. He contributes as co-shepherd of the attested build environment track, so being able to manage issues and approve PRs in this track would be really helpful. Relevant contributions to the track: * PR review: #1115 (review) * PR review: #1244 (review) * Issue discussion: #1253 * Issue discussion: #1267 * Issue discussion: #1150 Signed-off-by: Marcela Melara <marcela.melara@intel.com>
This PR introduces the following spec changes associated with #975. The spec enhancements are being proposed as the new "build Environment track".
Spec changes: Adds new high-level build environment terminology and levels.
Part 1 of #975 CC @paveliak