fix: resolve secret references in HTTP headers #284
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the bug where secret references (e.g., ${env:CONTEXT7_API_KEY})
in HTTP headers were not being resolved before passing to upstream servers.
The resolution logic existed for environment variables and arguments but
was missing for headers, causing raw placeholder strings to be sent in
HTTP requests instead of actual secret values.
Changes:
- Added header secret resolution in NewClientWithOptions after args resolution
- Mirrors the same pattern used for env vars and args resolution
- Added comprehensive test suite with 4 test cases covering:
* Single secret resolution in headers
* Multiple secrets in different headers
* No headers (nil) case
* Static headers without secret references
This fix enables proper authentication with services like Context7 that
require API keys in headers using the secret management system.
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Dumbris
approved these changes
Jan 29, 2026
Contributor
Dumbris
left a comment
Dumbris
left a comment
There was a problem hiding this comment.
Thank you for your contribution!
This is a clear improvement to the UX.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the bug where secret references (e.g., ${env:CONTEXT7_API_KEY}) in HTTP headers were not being resolved before passing to upstream servers.
The resolution logic existed for environment variables and arguments but was missing for headers, causing raw placeholder strings to be sent in HTTP requests instead of actual secret values.
Changes:
This fix enables proper authentication with services like Context7 that require API keys in headers using the secret management system.
Pull Request
Description
Brief description of the changes in this PR.
Testing