Skip to content

SIM-1146 CSync only if not null, test added. #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lowendavid wants to merge 2 commits into from
Closed

SIM-1146 CSync only if not null, test added. #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f345a85
SIM-1146 CSync only if not null, test added.
lowendavid Jul 14, 2021
548c717
SIM-1146 added multi mediatype in .md file
lowendavid Aug 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/smartadserverBidAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ export const spec = {
*/
getUserSyncs: function (syncOptions, serverResponses) {
const syncs = [];
if (syncOptions.iframeEnabled && serverResponses.length > 0) {
if (syncOptions.iframeEnabled && serverResponses.length > 0 && serverResponses[0].body.cSyncUrl != null) {
syncs.push({
type: 'iframe',
url: serverResponses[0].body.cSyncUrl
Expand Down
38 changes: 34 additions & 4 deletions modules/smartadserverBidAdapter.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,11 +110,11 @@ Please reach out to your Technical account manager for more information.
renderer: {
url: 'https://acdn.adnxs.com/video/outstream/ANOutstreamVideo.js',
render: function (bid) {
bid.renderer.push(() => {
ANOutstreamVideo.renderAd({
bid.renderer.push(() => {
ANOutstreamVideo.renderAd({
targetId: bid.adUnitCode,
adResponse: bid
});
adResponse: bid
});
});
}
},
Expand All @@ -133,4 +133,34 @@ Please reach out to your Technical account manager for more information.
}
}]
};
```

## Double Mediatype Setup (Banner & Video)

```
var adUnits = [{
code: 'prebid_tag_001',
mediaTypes: {
banner: {
sizes: [[300,250]]
},
video: {
context: 'outstream',
playerSize: [640, 480]
}
},
bids: [{
bidder: 'smartadserver',
params: {
domain: 'https://prg.smartadserver.com',
siteId: 411951,
pageId: 1383641,
formatId: 84313,
target: 'iid=8984466',
video: {
protocol: 6, // Stands for "up to VAST 3". For "up to VAST 4" it is 8
}
}
}]
}];
```
21 changes: 21 additions & 0 deletions test/spec/modules/smartadserverBidAdapter_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,22 @@ describe('Smart bid adapter tests', function () {
}
};

var BID_RESPONSE_IFRAME_SYNC_MISSING_CSYNC = {
body: {
cpm: 12,
width: 300,
height: 250,
creativeId: 'zioeufg',
currency: 'GBP',
isNetCpm: true,
ttl: 300,
adUrl: 'http://awesome.fake.url',
ad: '< --- awesome script --- >',
cSyncUrl: null,
isNoAd: false
}
};

it('Verify build request', function () {
config.setConfig({
'currency': {
Expand Down Expand Up @@ -302,6 +318,11 @@ describe('Smart bid adapter tests', function () {
iframeEnabled: true
}, []);
expect(syncs).to.have.lengthOf(0);

syncs = spec.getUserSyncs({
iframeEnabled: true
}, [BID_RESPONSE_IFRAME_SYNC_MISSING_CSYNC]);
expect(syncs).to.have.lengthOf(0);
});

it('Verifies user sync using dspPixels', function () {
Expand Down