Skip to content

Feature/fix visibility #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lhmgrassi merged 5 commits into from
Jul 27, 2018
Merged

Feature/fix visibility #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5e2a34d
Merge pull request #13 from smartmobilefactory/development
tschob Jun 21, 2018
b3b9002
Release version 2.1.0
Jun 21, 2018
a066223
Fix old tag scheme in Podspec
Jun 21, 2018
7629cd6
replace windowlevel 0 with constant UIWindowLevelNormal
pokchy Jul 27, 2018
b8d638f
hide window when dismissing
pokchy Jul 27, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions PasscodeLock/PasscodeLockPresenter.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ open class PasscodeLockPresenter {

let window = UIWindow(frame: UIScreen.main.bounds)

window.windowLevel = 0
window.windowLevel = UIWindowLevelNormal
window.makeKeyAndVisible()

return window
Expand Down Expand Up @@ -122,8 +122,9 @@ open class PasscodeLockPresenter {

} else {

passcodeLockWindow.windowLevel = 0
passcodeLockWindow.windowLevel = UIWindowLevelNormal
passcodeLockWindow.rootViewController = nil
passcodeLockWindow.isHidden = true
Copy link
Copy Markdown

@lhmgrassi lhmgrassi Jul 27, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra tab?

Copy link
Copy Markdown
Author

@pokchy pokchy Jul 27, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope other indentations are with whitespaces
when I added this line my indentations are with tabs
should I refactor class to use tabs instead of whitespaces ?

Copy link
Copy Markdown

@lhmgrassi lhmgrassi Jul 27, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so :)

}
}

Expand All @@ -141,8 +142,9 @@ open class PasscodeLockPresenter {
},
completion: { [weak self] _ in

self?.passcodeLockWindow.windowLevel = 0
self?.passcodeLockWindow.windowLevel = UIWindowLevelNormal
self?.passcodeLockWindow.rootViewController = nil
self?.passcodeLockWindow.isHidden = true
Copy link
Copy Markdown

@lhmgrassi lhmgrassi Jul 27, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra tab?

Copy link
Copy Markdown
Author

@pokchy pokchy Jul 27, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above

self?.passcodeLockWindow.alpha = 1
}
)
Expand Down
4 changes: 2 additions & 2 deletions SMFPasscodeLock.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,11 @@

Pod::Spec.new do |s|
s.name = 'SMFPasscodeLock'
s.version = '2.0.1'
s.version = '2.1.0'
s.license = { :type => "MIT", :file => 'LICENSE.txt' }
s.summary = 'SMF Fork of PasscodeLock: An iOS passcode lock with Touch ID authentication written in Swift.'
s.homepage = 'https://github.com/smartmobilefactory/SwiftPasscodeLock'
s.source = { :git => 'https://github.com/smartmobilefactory/SwiftPasscodeLock.git', :tag => "versions/#{s.version}" }
s.source = { :git => 'https://github.com/smartmobilefactory/SwiftPasscodeLock.git', :tag => "releases/#{s.version}" }
s.authors = [{ 'Ramiro Ramirez' => '' }, { 'Yanko Dimitrov' => '' }, { 'Hans Seiffert' => '' }]

s.ios.deployment_target = '8.0'
Expand Down