Add chromaticAberration post-process effect and renderer sourceCanvas hook#261
Open
Add chromaticAberration post-process effect and renderer sourceCanvas hook#261
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
chromaticAberrationinsrc/renderer/effects/chromaticAberration.tswith exportedCHROMATIC_ABERRATION_DEFAULTS,resolveChromaticAberrationParams,applyChromaticAberrationToData, andChromaticAberrationEffectthat samples an input canvas, offsets channels radially/directionally, supportssampleStepblock rendering, and blends viaalpha.src/renderer/effects/manifest/chromaticAberration.manifest.tsand registered the effect in the generated manifest list so it appears in the registry and debug/editor dropdowns; provided debug controls and docs metadata (includingmodeselect:rgb|rg|rb|gb).sourceCanvas?: HTMLCanvasElement(src/renderer/effects/types.ts) and wiredRenderer.renderEffectTo/ layer rendering to passsceneCanvasas thesourceCanvaswhen rendering layers, so post effects can process prior composited imagery (src/renderer/renderer.ts).docs/effects.mdregenerated andREADME.mdEffect catalog) to include the new effect and added unit testssrc/renderer/effects/chromaticAberration.test.tscovering param clamping, centre stability, andsampleStepblock behaviour; also updated the release timeline test optional list to include the new key.Testing
npm run docs:effects(succeeded) andnpm run docs:check(succeeded).npx vitest run src/timeline/releaseTimeline.test.ts src/renderer/effects/effectCatalogDocs.test.ts src/renderer/effects/chromaticAberration.test.tsand all targeted tests passed.npm test; all unit/core tests passed locally, with a single failing integration test (api/kv.integration.test.ts) that failed due to external networkENETUNREACHto Upstash in this environment and is unrelated to the effect.docs/effects.md(total effects increased accordingly).Codex Task