Add ssao_post post-process effect with WebGL2 shader and Canvas2D fallback#262
Open
Add ssao_post post-process effect with WebGL2 shader and Canvas2D fallback#262
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
src/renderer/effects/gl/ssaoPostEffect.ts.src/renderer/effects/ssaoPostCanvas.tsand helpers insrc/renderer/effects/ssaoPostCanvas.test.ts.src/renderer/effects/ssaoPostEffect.tsand exportedSSAO_POST_DEFAULTS.src/renderer/effects/manifest/ssao_post.manifest.ts,src/renderer/effects/manifest/generated.ts,src/renderer/renderer.ts,README.md, and regenerateddocs/effects.md.ssao_post.Testing
npm run docs:effectswhich regenerateddocs/effects.mdand updated the effect catalog successfully. (succeeded)npm run docs:checkwhich passed. (succeeded)src/renderer/effects/ssaoPostCanvas.test.ts(luminance and AO clamp) and ran the test suite excluding an unreachable external integration test;npx vitest run --exclude api/kv.integration.test.tspassed all tests locally. (succeeded)npm testin this environment initially reported a failing integration testapi/kv.integration.test.tsdue to networkENETUNREACH(external DB unreachable), and an unrelated release-timeline assertion which was updated in this change and then re-run; the functional changes to effects and renderer passed the automated tests when integration tests are excluded. (integration test failure is environmental)Codex Task