Add shadowVolumes Canvas effect with docs, manifest, and tests#264
Open
Add shadowVolumes Canvas effect with docs, manifest, and tests#264
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
shadowVolumesthat evokes classic hard-edged shadow-volume silhouettes using deterministic projected geometry and audio-reactive motion.seedand can be automated from the timeline/editor.Description
ShadowVolumesEffectinsrc/renderer/effects/shadowVolumes.tswith projection helpers, seeded occluder generation, shadow-polygon construction, era tweaks, and audio reactivity.src/renderer/effects/manifest/shadow_volumes.manifest.tsand included it in the generated manifest list (src/renderer/effects/manifest/generated.ts).src/renderer/effects/shadowVolumes.test.tscovering param resolution/clamping, deterministic occluder generation, projection stability, and finite shadow polygon output.README.mdand regenerateddocs/effects.mdso the effect appears in the registry/docs and the debug dropdowns.public/timeline.release.jsonso release coverage tests include the new effect.Testing
npm run test -- src/renderer/effects/shadowVolumes.test.tsand they passed.npm run docs:effectsand verified docs consistency vianpm run docs:check, both succeeded.src/timeline/releaseTimeline.test.ts,src/renderer/effects/effectCatalogDocs.test.ts) and they passed after adding a small layer reference in the release timeline.npm run test; all project tests passed except an external integration testapi/kv.integration.test.tswhich failed due to network DB reachability in this environment (ENETUNREACH) and is unrelated to the effect changes.Codex Task