Add heat_haze effect — Canvas2D localized heat-shimmer with manifest, docs & tests#265
Open
Add heat_haze effect — Canvas2D localized heat-shimmer with manifest, docs & tests#265
heat_haze effect — Canvas2D localized heat-shimmer with manifest, docs & tests#265Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
getImageDatawork and reusing offscreen buffers.Description
src/renderer/effects/heatHaze.tsasHeatHazeEffect, using an offscreen canvas and strip-based horizontal displacement driven by layered seeded value-noise, sinusoidal shimmer, and upward advection; a subtle vertical offset and small second-pass softening are included (blurHint).noise1dandvalueNoise1d, and a region-weighting helpergetRegionWeightto supportregion=bottom|band|fullwithcenterY,height, andfeathercontrols.src/renderer/effects/manifest/heat_haze.manifest.tsand added the manifest into the generated registry list (src/renderer/effects/manifest/generated.ts) so it appears in the UI/debug dropdowns.docs/effects.mdso the effect is documented and the docs generator can parse its parameters (scripts/generateEffectsDocs.ts).src/renderer/effects/heatHaze.test.tsfor helper determinism and region weighting, and adjustedsrc/timeline/releaseTimeline.test.tsoptional list to includeheat_hazeso registry coverage tests remain valid.intensity,speed,scale,drift,region,centerY,height,feather,shimmer,blurHint,tint,audioReactive,beatBoost,bassInfluence,seed.Testing
npm run docs:effectsand verified vianpm run docs:check; docs generation succeeded and docs check passed.npx vitest run src/renderer/effects/heatHaze.test.ts src/timeline/releaseTimeline.test.ts; both test files passed.npm test; all project tests passed except an existing external integration testapi/kv.integration.test.tswhich failed due to network/Upstash connectivity (ENETUNREACH) in the current environment and is unrelated to the effect code.Codex Task