Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
src/effectPreviewAudio.tsimplementingEffectPreviewAudioControllerwith exact anchors and loop bounds (start 05:12.850, loop05:39.940 → 05:50.786) and reduced preview volume (0.2).src/main.tsso the controller starts when the modal opens, stops when it closes, and supplies liveAudioFeaturesto generated-effect rendering.src/effectReview.tsso approval previews use the same looping audio and live features.setVolume()tosrc/audio/audioPlayer.tsto allow quiet preview playback and add lifecycle/cleanup logic (stop/destroy on unload and when sources change).README.mdto document the new preview-audio behavior and addsrc/effectPreviewAudio.test.tsunit tests covering loop timing behavior.Testing
npm test -- src/effectPreviewAudio.test.ts src/effectReview.test.ts src/style.test.tsand all tests passed (3 files, 8 tests total).npm run buildwhich completed successfully.Codex Task