Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
index.html,src/style.css).src/main.tsand addedsrc/effectIdeaUx.tsutilities for BPM timing, deterministic shuffle, and name sanitization; the flow now primes an approved-effects showcase during generation, shows a single busy sheet spinner, displays a retry error state, runs a 3-2-1 countdown at 177 BPM, then reveals the generated effect via a shatter animation and enables submission.paramspayload automatically at submission time, and added client-side name sanitization with a sensible maxlength.src/effectIdeaUx.test.ts(unit tests for helpers), updatedsrc/style.test.tsexpectations, and updated README notes about the generator UX and defaults behavior.Testing
npm test -- --run src/effectIdeaUx.test.ts src/style.test.ts src/generatedEffectControls.test.ts src/effectIdeas.test.ts, and all tests passed (24 passed).npm run buildwhich completed successfully (vite build finished).Codex Task