Show and tweak approved community effect params during generation#339
Open
Show and tweak approved community effect params during generation#339
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
index.html) that shows the currently previewed approved effect name and inline param controls.renderEffectIdeaParamControlsandrenderBusyCommunityEffectControlsinsrc/main.ts, refactored the generated-effect controls to reuse the shared renderer, and wired carousel entries to carry both default values andparamDefsmetadata.src/style.cssand updated the README generator UX copy; updatedsrc/style.test.tsto assert new markup/CSS expectations.Testing
npm test -- src/style.test.tsand the style tests passed.npm run buildand the production build completed successfully.Codex Task