Skip to content

Show approved community effect params while generating (busy-carousel tweaks)#340

Open
smcga wants to merge 1 commit intomainfrom
codex/add-parameters-for-community-effects-checkout
Open

Show approved community effect params while generating (busy-carousel tweaks)#340
smcga wants to merge 1 commit intomainfrom
codex/add-parameters-for-community-effects-checkout

Conversation

@smcga
Copy link
Copy Markdown
Owner

@smcga smcga commented Apr 8, 2026

Motivation

  • While the generator is running and approved community effects are shown in the waiting carousel, users should be able to see and tweak those effects' params to experiment without interrupting the generation flow.
  • This change aims to surface generated/approved effect parameter metadata during the busy state only, preserving the existing generation/submission UX and defaults behavior.

Description

  • Added compact busy-state markup in index.html (#effect-idea-busy-controls, #effect-idea-busy-controls-grid, #effect-idea-busy-controls-empty) to host live parameter controls while generating.
  • Extended carousel entries in src/main.ts to carry param metadata (controls) and wired renderEffectIdeaBusyControls to render number, select, and toggle inputs that update effectIdeaPreviewParams live for previews.
  • Toggled busy-controls visibility in setEffectIdeaBusyState, reset busy controls on modal open/close, and preserved the existing generated-params submission path (applyCurrentValuesAsGeneratedDefaults).
  • Added compact CSS rules in src/style.css for the busy-controls block and updated the README to document live tweaking during the generation wait; also updated style regression assertions in src/style.test.ts.

Testing

  • Ran npm test -- --run src/style.test.ts src/generatedEffectControls.test.ts and both test files passed (src/style.test.ts and src/generatedEffectControls.test.ts all tests green).
  • Style/test assertions were updated to assert the new busy-controls markup and styles and succeeded locally.

Codex Task

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 8, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
codexperimental Ready Ready Preview, Comment Apr 8, 2026 0:03am

Request Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant