Remove greets_wall effect and migrate timeline usage to doodle_greetz_wall#343
Open
Remove greets_wall effect and migrate timeline usage to doodle_greetz_wall#343
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
greets_walleffect and using the existingdoodle_greetz_wallfor timeline slots.Description
greets_wallimplementation, its tests, and its manifest (src/renderer/effects/greetsWall.ts,src/renderer/effects/greetsWall.test.ts,src/renderer/effects/manifest/greets_wall.manifest.ts).doodle_greetz_wallto own its defaults and sequence-index helper (moved inlined defaults and addedresolveDoodleWallSequenceIndex) so it no longer depends on the removed greets code (src/renderer/effects/doodleGreetzWall.ts).greets_wallwithdoodle_greetz_wallinpublic/timeline.release.jsonwithout changing any timestamps or section boundaries.greets_walland regenerate effects/chronology docs and README entries (src/renderer/effects/manifest/generated.ts,docs/effects.md,docs/effect-chronology.md,README.md).greets_wallto usedoodle_greetz_wall, and added unit coverage for the doodle wall sequence-index helper (src/renderer/effects/doodleGreetzWall.test.ts,src/debug/debugPanel.test.ts,src/renderer/debug/effectDebug.test.ts).Testing
npm run docs:effectsandnpm run docs:chronologyand regenerateddocs/effects.mdanddocs/effect-chronology.mdsuccessfully.npm run docs:checkwhich passed (effects/transitions docs tests passed).npm test; the test run surfaced a pre-existing unrelated failure insrc/timeline/timelineAudioParams.test.ts(assertion aboutspoken-word-b kickImpulse> 0.2), so overall CI shows one failing test unrelated to this change.npx vitest runfor doodle greetz wall, debug, manifest, timeline release tests, chronology/docs tests) and all targeted tests passed.Codex Task