Skip to content

Remove greets_wall effect and migrate timeline usage to doodle_greetz_wall#343

Open
smcga wants to merge 1 commit intomainfrom
codex/remove-greetz-wall-effect-and-replace-with-doodle-wall
Open

Remove greets_wall effect and migrate timeline usage to doodle_greetz_wall#343
smcga wants to merge 1 commit intomainfrom
codex/remove-greetz-wall-effect-and-replace-with-doodle-wall

Conversation

@smcga
Copy link
Copy Markdown
Owner

@smcga smcga commented Apr 8, 2026

Motivation

  • Consolidate wall-style behaviour by removing the duplicated greets_wall effect and using the existing doodle_greetz_wall for timeline slots.
  • Keep the timeline structure and sacred anchor timings unchanged while swapping effect names.
  • Ensure docs and effect registry stay accurate after removing an effect.

Description

  • Deleted the greets_wall implementation, its tests, and its manifest (src/renderer/effects/greetsWall.ts, src/renderer/effects/greetsWall.test.ts, src/renderer/effects/manifest/greets_wall.manifest.ts).
  • Updated doodle_greetz_wall to own its defaults and sequence-index helper (moved inlined defaults and added resolveDoodleWallSequenceIndex) so it no longer depends on the removed greets code (src/renderer/effects/doodleGreetzWall.ts).
  • Replaced the single timeline usage of greets_wall with doodle_greetz_wall in public/timeline.release.json without changing any timestamps or section boundaries.
  • Updated generated manifest list and chronology/docs to remove greets_wall and regenerate effects/chronology docs and README entries (src/renderer/effects/manifest/generated.ts, docs/effects.md, docs/effect-chronology.md, README.md).
  • Adjusted tests and debug expectations that referenced greets_wall to use doodle_greetz_wall, and added unit coverage for the doodle wall sequence-index helper (src/renderer/effects/doodleGreetzWall.test.ts, src/debug/debugPanel.test.ts, src/renderer/debug/effectDebug.test.ts).

Testing

  • Ran npm run docs:effects and npm run docs:chronology and regenerated docs/effects.md and docs/effect-chronology.md successfully.
  • Ran npm run docs:check which passed (effects/transitions docs tests passed).
  • Ran full test suite via npm test; the test run surfaced a pre-existing unrelated failure in src/timeline/timelineAudioParams.test.ts (assertion about spoken-word-b kickImpulse > 0.2), so overall CI shows one failing test unrelated to this change.
  • Ran a focused Vitest subset covering the changed areas (npx vitest run for doodle greetz wall, debug, manifest, timeline release tests, chronology/docs tests) and all targeted tests passed.

Codex Task

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 8, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
codexperimental Ready Ready Preview, Comment Apr 8, 2026 0:38am

Request Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant