Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
Community paramstoggle with live param controls.Escapefrom closing the effect idea modal while generation is active and show a busy-block message viagetEffectIdeaCloseBlockedMessage.src/effectIdeaModalClose.tswith functionsgetEffectIdeaCloseBlockedMessageandshouldShowCommunityCarouselButtonsand add unit tests insrc/effectIdeaModalClose.test.ts.renderEffectIdeaParamControls) and wire them into the busy panel (renderBusyCommunityEffectControls), hydrate carousel entries withparamDefs, and keep carousel nav buttons visible per the new visibility logic.index.html) to include the busy controls toggle and preview stage wrapper, and add corresponding styles insrc/style.css.src/main.tsto manage new state (effectIdeaBusyControlsExpanded), wire up event handlers for the new toggle, and replace direct modal-close calls withcloseEffectIdeaModalIfAllowed.Testing
vitest, including the neweffectIdeaModalClosetests and existingstyle.test.tsassertions, and the suite passed.style.test.tschecks for new classes and layout attributes, which succeeded.Codex Task