Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
tetris_matrixeffect feel more impressive and responsive by adding combo-driven visual energy and subtle motion without changing gameplay/timeline behavior.speed,level,glow,contrast,ghost,seed) while improving visual feedback tied to audio/line clears.Description
getRecentLineBurstsand computecomboPulse,burstEnergy, andintensityto drive visuals.ctx.translate(shakeX, shakeY)and strengthen reactive screen glow by foldingcomboPulseandintensityintoscreenGlow.HOT/SYNC/CALM) driven bycomboPulseandaudio.beat.src/renderer/effects/tetrisMatrixEffect.ts, update effect manifest and README descriptions, and regeneratedocs/effects.md.src/renderer/effects/tetrisMatrixEffect.test.ts) to mockctx.translateand assert the shake translation and HUD label rendering.Testing
npm run test -- src/renderer/effects/tetrisMatrixEffect.test.ts src/renderer/debug/effectDebug.test.ts, and all tests passed (48 tests total).npm run docs:effectsand ran docs checks withnpm run docs:check, and both checks passed.Codex Task