Add point-driven automation clip editing utilities#369
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
src/editor/automationClip.tswhich definesAutomationClip,ControlPoint,SegmentMeta,CurveType, and implements helpers:createAutomationClip,snapTime,insertPoint,removePoint,movePoint(with slide-mode),setSegmentTension, andsetSegmentCurveTypewith clamping and segment metadata normalization.MIN_POINTS) and clamp point values/tension ranges to valid bounds in the model operations.src/editor/automationClip.test.tscovering grid snapping, insertion/removal with minimum-point safety, move behavior with and without slide mode, and per-segment tension/curve-type updates.README.mdtimeline/editor notes to document the new automation-clip editing foundations for UI integration.Testing
npm test -- src/editor/automationClip.test.ts src/editor/EditorRoot.test.tsand all tests passed.2test files executed and67tests passed (no failures).Codex Task