Skip to content

Add editor-mode global keyboard playback hotkeys#370

Open
smcga wants to merge 1 commit intomainfrom
codex/add-global-hotkeys-in-editor-mode
Open

Add editor-mode global keyboard playback hotkeys#370
smcga wants to merge 1 commit intomainfrom
codex/add-global-hotkeys-in-editor-mode

Conversation

@smcga
Copy link
Copy Markdown
Owner

@smcga smcga commented Apr 28, 2026

Motivation

  • Provide convenient keyboard controls in the Scene + Timeline Editor for faster playback iteration without interfering with form inputs or other page focus.

Description

  • Add a small, testable editor hotkey mapper getEditorShortcutAction in src/controls.ts that maps Spacetoggle-playback, ArrowLeftseek-backward, and ArrowRightseek-forward.
  • Wire editor-only handling into the global keydown handler in src/main.ts so shortcuts run only when the editor is visible (editorController?.isVisible()) and shouldHandleGlobalShortcut allows (no focused editable target), call preventDefault() for handled keys, and broadcast actions via the existing playbackSync.
  • Update editor docs in README.md to document the new hotkeys.

Testing

  • Added unit tests for getEditorShortcutAction in src/controls.test.ts and ran npm test -- src/controls.test.ts, which passed (17 tests, all green).

Codex Task

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 28, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
codexperimental Ready Ready Preview, Comment Apr 28, 2026 11:00pm

Request Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant