Skip to content

[pull] master from atom:master #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pull merged 2 commits into from
Jul 29, 2021
Merged

[pull] master from atom:master #41

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fc5286f
Use custom elements on text editor element spec
sadick254 Jul 29, 2021
f37fc2a
Merge pull request #22789 from atom/use-custom-element-on-text-editor…
sadick254 Jul 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions spec/text-editor-element-spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,15 +218,16 @@ describe('TextEditorElement', () => {
});

describe('when focused while a parent node is being attached to the DOM', () => {
class ElementThatFocusesChild extends HTMLDivElement {
attachedCallback() {
class ElementThatFocusesChild extends HTMLElement {
connectedCallback() {
this.firstChild.focus();
}
}

document.registerElement('element-that-focuses-child', {
prototype: ElementThatFocusesChild.prototype
});
window.customElements.define(
'element-that-focuses-child',
ElementThatFocusesChild
);

it('proxies the focus event to the hidden input', () => {
const element = buildTextEditorElement();
Expand Down