[pull] master from atom:master#74
Merged
pull[bot] merged 7 commits intosmilers:masterfrom Sep 20, 2021
Merged
Conversation
We don't actually support Node older than 10 for successfully bootstrapping an Atom build, but we should support older Node in the system requirements checker script so that we can print useful errors, like ones to tell the user their system's copy of Node is too old! (It was me that introduced this Node 10.0.0 or above-only syntax about a year ago... My mistake. It's as good a time as any to fix it!)
The periods for return types are inconsistent
"Node 10.12 or newer" has been a hard requirement since this PR: #20879, due to newer versions of electron-chromedriver and electron-mksnapshot relying on extract-zip@2 as an indirect dependency. (extract-zip@2 requires Node 10.12 or newer for its recursive mkdir. Using extract-zip@2 with Node older than 10.12 results in errors. That leads to a lack of electron-vendored chromedriver or mksnapshot binaries where they're supposed to be. Which in turn causes startup blob creation (via mksnapshot) to fail toward the end of the Atom build scripts.)
bootstrap: Update Node requirement to 10.12+ in system requirement checker
…cker-node bootstrap: Use legacy-compatible `catch` syntax (support older Node)
Remove duplicate `to`
Remove deprecated code strings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )