fix: detect non-interactive shells in auth login and publish#709
Open
fix: detect non-interactive shells in auth login and publish#709
Conversation
When `smithery auth login` is run from a non-interactive context (e.g. Claude Code, scripts, CI), it would hang silently waiting for an OAuth browser callback. Similarly, `smithery mcp publish` would hang trying to prompt for an API key via inquirer. - auth login: detect !process.stdin.isTTY and exit with a clear error - ensureApiKey: when no API key and no TTY, error instead of prompting - ensureApiKey: when API key is invalid and no TTY, error instead of re-prompting Fixes SMI-1698 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
smithery auth login: Detects non-interactive shells (!process.stdin.isTTY) and exits with a clear error message instead of hanging while waiting for an OAuth browser callback that will never arrive.smithery mcp publish/ensureApiKey: When no API key is found and the shell is non-interactive, exits with an actionable error ("Runsmithery auth loginin your terminal first") instead of hanging on an inquirer prompt. Same behavior when an existing key is invalid.smithery auth login(wassmithery login).Test plan
echo | smithery auth login— should print error and exit immediatelyecho | smithery mcp publish --name test— should print auth error and exitsmithery auth loginin a real terminal still works as beforeFixes SMI-1698
🤖 Generated with Claude Code