fix(adsb): disable bias-T on stop and warn when toggled while running#207
Merged
fix(adsb): disable bias-T on stop and warn when toggled while running#207
Conversation
The RTL-SDR bias-T hardware register persists after the device is closed, so toggling bias-T off in the UI and stopping the SDR had no effect on the actual hardware — verified with a multimeter in issue #205. - Add disable_bias_t_via_rtl_biast() to rtlsdr.py (mirrors enable, uses -b 0) - Track adsb_bias_t_active in adsb.py; call disable on stop_adsb() so the hardware register is cleared when ADS-B is stopped - Show an inline warning in the UI when the bias-T checkbox is toggled while any SDR mode is active, since the setting only takes effect at start time Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #205
Root causes
The RTL-SDR bias-T state is a hardware register that persists after the device is closed. Two bugs meant it could not be reliably controlled from the UI:
rtl_biast -b 0was never called on stop — so once bias-T was switched on, it stayed on until the dongle was physically unplugged or manually resetChanges
utils/sdr/rtlsdr.py: Addeddisable_bias_t_via_rtl_biast()— mirrors the existing enable function but passes-b 0routes/adsb.py: Addedadsb_bias_t_activeto track whether bias-T was enabled at start;stop_adsb()now callsdisable_bias_t_via_rtl_biast()before releasing the devicetemplates/index.html:saveBiasTSetting()now shows an inline warning when any SDR mode is running, making clear the change requires a restartTest plan
rtl_biastis not called unnecessarily🤖 Generated with Claude Code