Skip to content

refactor(main_no_modal.py): add check for file_path ending with "/" before writing to file#59

Merged
swyxio merged 2 commits intosmol-ai:mainfrom
jonnyhoff:main
Jun 21, 2023
Merged

refactor(main_no_modal.py): add check for file_path ending with "/" before writing to file#59
swyxio merged 2 commits intosmol-ai:mainfrom
jonnyhoff:main

Conversation

@jonnyhoff
Copy link
Copy Markdown

style(main_no_modal.py): change openai_model from gpt-4 to gpt-3.5-turbo
refactor(main_no_modal.py): add check for file_path ending with "/" before writing to file

style(main_no_modal.py): change openai_model from gpt-4 to gpt-3.5-turbo
refactor(main_no_modal.py): add check for file_path ending with "/" before writing to file
@swyxio
Copy link
Copy Markdown
Contributor

swyxio commented Jun 1, 2023

  1. lets make it respect a model flag, rather than just changing this constant
  2. why this check, what are the consequences of ignoring directory filepaths?

@jonnyhoff
Copy link
Copy Markdown
Author

  1. Changed the default model to rather be GPT3.5 because most people do not have access to GPT4.
  2. The check was added to address issue error when writing inside folders #26

@swyxio swyxio merged commit 299596e into smol-ai:main Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants