require emitter-component only#118
Closed
defunctzombie wants to merge 1 commit intosocketio:masterfrom
Closed
Conversation
It is confusing to have competing package managers within the same require system. The rest of the code uses npm published modules; this should too. We have tools which can bundle all of this properly without resorting to source code confusion.
Contributor
|
|
Contributor
Author
|
@guille using the npm syntax to target a repo sounds good. (It isn't that new, you can do git:// paths for a long time now. I usually do the following format: git://github.com/user/repo.git#abcdef Where abcdef are the commit hash of the version I want to use so that you don't go against master or some such. I also wouldn't call |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is confusing to have competing package managers within the same
require system. The rest of the code uses npm published modules; this
should too. We have tools which can bundle all of this properly
without resorting to source code confusion.