Flashsocket protocol does not work.#30
Merged
rauchg merged 2 commits intosocketio:masterfrom Jul 2, 2012
Merged
Conversation
mihs
commented
May 18, 2012
- Added code to FlashWS (imported from socket.io-client) to make it work.
- Added a policyPort option to Socket that is further send to FlashWS.
- Changed name of WebSocket import to WS in FlashWS to avoid name collision with WebSocket from web-socket.js and the native implementation of websockets.
- The check function is now a member of WS and FlashWS - this was done to be able to check what is the current transport to avoid the following problem: when reconnecting, WS on its own sees that there is a global WebSocket object, but that object may be the fake Flash WebSocket from web-socket.js. It then connects using that object, but the connection should have been done through FlashWS. Simply changing the name of the fake websocket will not work, it requires changing the action script source, which raises maintenance problems. Another solution could be to ask the maintainer of web-socket.js to add a configuration parameter.
rauchg
added a commit
that referenced
this pull request
Jul 2, 2012
Flashsocket protocol does not work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.