Skip to content

Flashsocket protocol does not work.#30

Merged
rauchg merged 2 commits intosocketio:masterfrom
mihs:master
Jul 2, 2012
Merged

Flashsocket protocol does not work.#30
rauchg merged 2 commits intosocketio:masterfrom
mihs:master

Conversation

@mihs
Copy link

@mihs mihs commented May 18, 2012

  • Added code to FlashWS (imported from socket.io-client) to make it work.
  • Added a policyPort option to Socket that is further send to FlashWS.
  • Changed name of WebSocket import to WS in FlashWS to avoid name collision with WebSocket from web-socket.js and the native implementation of websockets.
  • The check function is now a member of WS and FlashWS - this was done to be able to check what is the current transport to avoid the following problem: when reconnecting, WS on its own sees that there is a global WebSocket object, but that object may be the fake Flash WebSocket from web-socket.js. It then connects using that object, but the connection should have been done through FlashWS. Simply changing the name of the fake websocket will not work, it requires changing the action script source, which raises maintenance problems. Another solution could be to ask the maintainer of web-socket.js to add a configuration parameter.

rauchg added a commit that referenced this pull request Jul 2, 2012
Flashsocket protocol does not work.
@rauchg rauchg merged commit 082cda6 into socketio:master Jul 2, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants