[fix] Revert "default rejectUnauthorized to true"#496
Merged
darrachequesne merged 1 commit intosocketio:masterfrom Oct 5, 2016
Merged
[fix] Revert "default rejectUnauthorized to true"#496darrachequesne merged 1 commit intosocketio:masterfrom
rejectUnauthorized to true"#496darrachequesne merged 1 commit intosocketio:masterfrom
Conversation
This reverts commit 2c55b27, which breaks websocket transport under node v0.10 (socketio#494).
|
The original commit was a security fix, not sure reverting it is wise. |
Member
Author
|
@Nibbler999 thanks for the heads up! Support for node v0.10 will be dropped in next release. |
|
@Nibbler999 You can simply fix this issue by adding a validation of agent on the node v0.10 side. If |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 2c55b27, which breaks websocket transport under node v0.10 (#494).