try/catch xhr.responseType to avoid exception#590
Closed
xosofox wants to merge 2 commits intosocketio:masterfrom
Closed
try/catch xhr.responseType to avoid exception#590xosofox wants to merge 2 commits intosocketio:masterfrom
xosofox wants to merge 2 commits intosocketio:masterfrom
Conversation
The line can cause exceptions on Android 4.x in certain circumstances. Unfortunately, not reproducible but only visible when logging client errors in production, see socketio#589
Author
|
Close & Re-Open to trigger travis |
Member
|
It seems there is an issue with that pull request: #562 Which affects:
There is an exception when setting My concern is that, even with your fix, the client will not be able to connect, since it will not be able to parse the content sent by the server. It will not throw anymore though. Any suggestion? @Nibbler999 ? |
darrachequesne
added a commit
that referenced
this pull request
Feb 18, 2018
Some XHR implementations (like Firefox WebWorker, react-native and some Android 4.x versions) throw an exception when setting xhr.responseType = 'arraybuffer' when xhr.readyState === 2 (which is perfectly valid, spec-wise). That commit fixes that behaviour by reverting some of the changes from #562 for those implementations. Closes #590
5 tasks
darrachequesne
added a commit
that referenced
this pull request
Feb 18, 2018
Some XHR implementations (like Firefox WebWorker, react-native and some Android 4.x versions) throw an exception when setting xhr.responseType = 'arraybuffer' when xhr.readyState === 2 (which is perfectly valid, spec-wise). That commit fixes that behaviour by reverting some of the changes from #562 for those implementations. Fixes #589 Closes #590
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The line can cause exceptions on Android 4.x in certain circumstances.
Unfortunately, not reproducible but only visible when logging client errors in production, see #589
Note: the
engine.io.jsfile is the generated output ofmake engine.io.js, and should not be manually modified.The kind of change this PR does introduce
Current behaviour
When logging the JS errors our clients experience, we see quite some significant numbers of
INVALID_STATE_ERR: DOM Exception 11
in chrome on android 4.x and some opera browsers. It is not reproducible, though.
New behaviour
When putting the line in a try/catch, no more errors are logged AND there a no NEW ones, so it looks like it is improving the experience.
Other information (e.g. related issues)
#589