Skip to content

bugfix: Type improvements on "port" option in Socket and SocketOption… #680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
darrachequesne merged 1 commit into from
Nov 5, 2021
Merged

bugfix: Type improvements on "port" option in Socket and SocketOption… #680

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/socket.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ export interface SocketOptions {
/**
* The port for our connection. Set from the URI passed when connecting
*/
port: string;
port: string | number;

/**
* Any query parameters in our uri. Set from the URI passed when connecting
Expand Down Expand Up @@ -253,7 +253,7 @@ export class Socket extends Emitter<{}, {}, SocketReservedEvents> {
private readonly opts: Partial<SocketOptions>;
private readonly secure: boolean;
private readonly hostname: string;
private readonly port: string;
private readonly port: string | number;
private readonly transports: string[];

static priorWebsocketSuccess: boolean;
Expand Down