Make postcompile.sh script work on macOS#681
Merged
darrachequesne merged 2 commits intosocketio:masterfrom Nov 13, 2021
Merged
Conversation
Use the `bash` executable that appears first in user's `PATH`.
Contributor
Author
|
Fixed. |
e7667ca to
21fa6f5
Compare
On macOS the script is currently interpreted as the value of the `-i` option. Use an empty extension for the `-i` option and the `-e` option to specify the script.
21fa6f5 to
f41b8b2
Compare
Member
|
@lpinca thanks 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: the
engine.io.jsfile is the generated output ofmake engine.io.js, and should not be manually modified.The kind of change this PR does introduce
Current behaviour
The
npm run compilecommand does not work on macOS due to an invalid usage ofsedin thepostcompile.shscriptNew behaviour
npm run compileruns without errors on macOS.Other information (e.g. related issues)
First commit
Second commit