Reliability Improvements on Transport Tier#148
Closed
roamm wants to merge 8 commits intosocketio:masterfrom
Closed
Reliability Improvements on Transport Tier#148roamm wants to merge 8 commits intosocketio:masterfrom
roamm wants to merge 8 commits intosocketio:masterfrom
Conversation
This is to make it safe to call close() as many times as you wish. Right now it might be guaranteed in Socket, I think it's better to have it check here to avoid subtle problems in future.
… in socket.js Also check readyState against 'closed' to avoid wrong state transition.
…and when closing.
Contributor
|
@roamm can we make more focused pull requests? Like one for idempotent |
Contributor
|
Thanks! |
|
@guille, are there important failing test cases here? roamm@aa0209f |
darrachequesne
pushed a commit
that referenced
this pull request
May 8, 2020
Don't check against the window to detect node.js, wrap code in a try cat...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Firstly I'd like to say I don't run into any obvious bugs without these changes.
Because Socket has some implicit assumptions like:
These assumptions make the code kinda fragile so I took some time trying to fix it and hope this would help.