allowRequest failures now return 403 Forbidden#452
Merged
darrachequesne merged 1 commit intosocketio:masterfrom Dec 22, 2016
Merged
allowRequest failures now return 403 Forbidden#452darrachequesne merged 1 commit intosocketio:masterfrom
allowRequest failures now return 403 Forbidden#452darrachequesne merged 1 commit intosocketio:masterfrom
Conversation
Member
Author
|
Hej, how I can turn the CORS off to prevent things like this: |
Closed
darrachequesne
pushed a commit
that referenced
this pull request
May 8, 2020
added fallback to insertAt parentNode
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The kind of change this PR does introduce
Current behaviour
When
allowRequestoption is provided and fails for a request (for example when checking the allowed origins insocket.io), the client receives:New behaviour
The client will now receive a 403 response, without CORS headers.
Other information (e.g. related issues)
Closes #449
Related: #211 & #281