package.json main entry missing extension#608
Merged
darrachequesne merged 1 commit intosocketio:masterfrom Nov 8, 2020
AStoker:patch-1
Merged
package.json main entry missing extension#608darrachequesne merged 1 commit intosocketio:masterfrom AStoker:patch-1
darrachequesne merged 1 commit intosocketio:masterfrom
AStoker:patch-1
Conversation
The `main` entry for the `package.json` file is for defining the entry point. The entry is currently missing the required `.js` extension, this PR brings it back.
Member
|
Thanks! Out of curiosity, which tool needs the |
Contributor
Author
|
@darrachequesne, ran into it when trying to generate import maps with this tool: https://github.com/jsenv/jsenv-node-module-import-map |
darrachequesne
pushed a commit
that referenced
this pull request
Jun 6, 2022
The `main` entry for the `package.json` file is for defining the entry point. The entry is currently missing the required `.js` extension, this PR brings it back. Backported from 17b8c2f
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
mainentry for thepackage.jsonfile is for defining the entry point. The entry is currently missing the required.jsextension, this PR brings it back.The kind of change this PR does introduce
Current behaviour
The
mainentry in thepackage.jsonfile requires an extension that is currently lacking. This causes issues when tools try to automatically find themainfile based off thepackage.json(you end up with a file not found exception)New behaviour
Added the
.jsextension to the entry formain.jsOther information (e.g. related issues)
Resolves #607