import Node's setTimeout & clearTimeout to prevent ambiguity#632
Merged
darrachequesne merged 2 commits intosocketio:masterfrom Dec 14, 2021
Merged
import Node's setTimeout & clearTimeout to prevent ambiguity#632darrachequesne merged 2 commits intosocketio:masterfrom
darrachequesne merged 2 commits intosocketio:masterfrom
Conversation
Member
|
@JeffWinder thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The kind of change this PR does introduce
Current behaviour
setTimeoutin lib/socket.ts can lead to errorthis.pingIntervalTimer.refresh is not a functionbecause interpreter might see it as the javascript version, which doesn't have arefresh()function.New behaviour
Importing
setTimeoutandclearTimoutfrom Node'stimersmodule explicitly doesn't result in the error anymore.Other information (e.g. related issues)
Solves the bug in this issue: #631
The refresh() call was added here #628