fix the case when toJSON() returns a Buffer#2
Closed
chatziko wants to merge 2 commits intosocketio:masterfrom
Closed
fix the case when toJSON() returns a Buffer#2chatziko wants to merge 2 commits intosocketio:masterfrom
chatziko wants to merge 2 commits intosocketio:masterfrom
Conversation
Member
|
Merged as #6, thanks! |
Author
|
Thanks for the merge! Maybe it's a detail, but if the aim of That's why my fix was a bit more complicated than a recursive call. |
Member
Author
|
Looks good. (looking forward to a release to stop maintaining my own fork :D) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
has-binary assumes that toJSON() returns an object, but this is not necessary.
It incorrectly returns false for objects whose toJSON() returns a Buffer, eg:
Returning Buffer from toJSON is useful for classes who want to serialize themselves in binary when sent over socket.io.
The fix is simple, I also added a test.