fix compatibility problem for gcc 4.8+.#24
Merged
melode11 merged 1 commit intosocketio:masterfrom Jun 12, 2015
stefanhong:master
Merged
fix compatibility problem for gcc 4.8+.#24melode11 merged 1 commit intosocketio:masterfrom stefanhong:master
melode11 merged 1 commit intosocketio:masterfrom
stefanhong:master
Conversation
melode11
added a commit
that referenced
this pull request
Jun 12, 2015
fix compatibility problem for gcc 4.8+.
Contributor
|
Thanks, your patch is great. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I can't compile the code using gcc 4.8 nor gcc 4.9 on Linux without these fixes. The virtual destructor on message is straight forward, but I am not sure about the implication of removing const though. All test cases are passed. Also updated source files listed in README.md.