fix hardcoded resource during uri construction#28
Closed
antiqe wants to merge 1 commit intosocketio:masterfrom
antiqe:master
Closed
fix hardcoded resource during uri construction#28antiqe wants to merge 1 commit intosocketio:masterfrom antiqe:master
antiqe wants to merge 1 commit intosocketio:masterfrom
antiqe:master
Conversation
Contributor
|
This can not be merged because it can not cover such case like: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I corrected the resource that was hardcoded during the creation of the URI.
The connection should be :
Or maybe define the resource "/socket.io" by default if it is not specified during the connect call.