Skip to content

fix hardcoded resource during uri construction#28

Closed
antiqe wants to merge 1 commit intosocketio:masterfrom
antiqe:master
Closed

fix hardcoded resource during uri construction#28
antiqe wants to merge 1 commit intosocketio:masterfrom
antiqe:master

Conversation

@antiqe
Copy link
Copy Markdown

@antiqe antiqe commented Jun 22, 2015

I corrected the resource that was hardcoded during the creation of the URI.

The connection should be :

sio::client h;
h.connect("http://127.0.0.1:3000/socket.io");

Or maybe define the resource "/socket.io" by default if it is not specified during the connect call.

@melode11
Copy link
Copy Markdown
Contributor

This can not be merged because it can not cover such case like:

sio::client h;
h.connect("http://127.0.0.1:3000");

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants